chenBright commented on PR #3328: URL: https://github.com/apache/brpc/pull/3328#issuecomment-4642274989
At least in bazel CI (e.g., gcc-compile-with-bazel-all-options and clang-compile-with-bazel-all-options), you must ensure that io_uring compiles successfully. https://github.com/apache/brpc/blob/72adb6ec24a98247b0f6d8c2ce40a6fc3ae0c41b/.github/workflows/ci-linux.yml#L124-L139 https://github.com/apache/brpc/blob/72adb6ec24a98247b0f6d8c2ce40a6fc3ae0c41b/.github/workflows/ci-linux.yml#L183-L199 Could you add some unit tests for io_uring transport? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
