rajvarun77 commented on PR #2093: URL: https://github.com/apache/brpc/pull/2093#issuecomment-4536371681
Hi @yanglimingcn — picking up on your 2025-07-15 invitation for a successor. Thanks for the substantial work here; I'd like to help land it in stages. I am **not changing the design** of this PR. To make it reviewable and unblock merging incrementally, I plan to deliver the same scope as **four small follow-up PRs** rather than one large PR: 1. **Text protocol + `mysql_native_password`** *(in progress)* 2. Transactions (`MysqlTransaction`) 3. Prepared statements (`COM_STMT_*`, `Socket::_fd_version` ABA-safe stmt_id map per your design) 4. `caching_sha2_password` + TLS *(extension beyond this PR's scope)* This matches your original delivery split — [PR #691](https://github.com/apache/brpc/pull/691) (Mar 2019) was also text-protocol-only with transactions/prepared statements planned as follow-ups. For Stage 1, I will be: - rebasing onto current master (`PROTOCOL_MYSQL` slot 27 is now `PROTOCOL_COUCHBASE`; `Socket::WriteOptions::with_auth` → `auth_flags`) - reimplementing `mysql_auth_hash.cpp` clean-room (the existing one is GPL-licensed, flagged by @wwbmmm at https://github.com/apache/brpc/pull/2093#discussion_r1083736392) - addressing every text-protocol review comment from the original rounds (typos, style, license headers, `Socket::Write` return check, `New(Arena*)` overload, dead-code removal, etc.) - opening a fresh PR (not pushing to this branch) so your commit history stays intact and you can pick up Stages 2–4 yourself if you have time later @wwbmmm @chenBright — would either of you be available to review Stage 1 when it's up? Also posted to [email protected] for shepherd assignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
