yanglimingcn commented on code in PR #3300:
URL: https://github.com/apache/brpc/pull/3300#discussion_r3256874335
##########
src/brpc/rdma/rdma_helper.cpp:
##########
@@ -178,7 +178,7 @@ void* UserExtendBlockPool(void* region_base, size_t
region_size,
uint32_t RdmaRegisterMemory(void* buf, size_t size) {
// Register the memory as callback in block_pool
// The thread-safety should be guaranteed by the caller
- ibv_mr* mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE);
+ ibv_mr* mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE |
IBV_ACCESS_RELAXED_ORDERING);
Review Comment:
Some hardware devices may not support IBV_ACCESS_RELAXED_ORDERING. Could a
runtime checking mechanism be implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
