yanglimingcn commented on code in PR #3238:
URL: https://github.com/apache/brpc/pull/3238#discussion_r2902806986
##########
src/brpc/event_dispatcher.cpp:
##########
@@ -41,6 +51,15 @@ static bvar::LatencyRecorder* g_edisp_read_lantency = NULL;
static bvar::LatencyRecorder* g_edisp_write_lantency = NULL;
static pthread_once_t g_edisp_once = PTHREAD_ONCE_INIT;
+bool EventDispatcherUnsched() {
+#if BRPC_WITH_RDMA
+ return FLAGS_event_dispatcher_edisp_unsched ||
+ rdma::FLAGS_rdma_edisp_unsched;
+#else
+ return FLAGS_event_dispatcher_edisp_unsched;
+#endif
+}
Review Comment:
I think simply deleting rdma_edisp_unsched and replacing it with
event_dispatcher_edisp_unsched should suffice.
This is a very new feature, and no one is using it yet, so there's no need
to worry too much about compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
