wayslog commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3942784611
I investigated the flaky test failure in and pushed a fix:\n\n- commit: \n-
root cause: ASK redirection was being written into the slot cache, which is
incorrect (ASK is temporary during migration).\n- effect: subsequent requests
could be routed directly to the ASK target without sending , then return
intermittently under concurrency.\n- fix: only persist slot mapping for MOVED,
not ASK.\n- test: added and re-ran //test:brpc_redis_cluster_test
(cached) PASSED in 4.3s
Executed 0 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the
--test_verbose_timeout_warnings command line option to see which ones these
are..\n\nThis should eliminate the CI flake for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
