wwbmmm commented on code in PR #2923:
URL: https://github.com/apache/brpc/pull/2923#discussion_r2008994921


##########
src/brpc/server.h:
##########
@@ -601,6 +601,16 @@ class Server {
     int MaxConcurrencyOf(google::protobuf::Service* service,
                          const butil::StringPiece& method_name) const;
 
+    // Reset max_concurrency associated with a method.
+    int ResetMaxConcurrencyOf(const butil::StringPiece& full_method_name,

Review Comment:
   就是涉及method的方法(如MaxConcurrencyOf, 
ResetMaxConcurrencyOf),目前都得实现三种重载(三种查找Method的方法)
   如果后面操作method的方法越来越多,就需要实现很多方法
   
所以我想Server类可以提供一个方法获取method对象(包含三种重载),获取到method对象后直接对其进行操作,就不需要在Server这个类实现很多方法



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to