wwbmmm commented on code in PR #2754:
URL: https://github.com/apache/brpc/pull/2754#discussion_r1743403854
##########
src/brpc/stream_impl.h:
##########
@@ -63,8 +63,11 @@ class BAIDU_CACHELINE_ALIGNMENT Stream : public
SocketConnection {
void FillSettings(StreamSettings *settings);
static int SetFailed(StreamId id, int error_code, const char* reason_fmt,
...)
__attribute__ ((__format__ (__printf__, 3, 4)));
+ static int SetFailed(const StreamIds& ids, int error_code, const char*
reason_fmt, ...)
+ __attribute__ ((__format__ (__printf__, 3, 4)));
void Close(int error_code, const char* reason_fmt, ...)
__attribute__ ((__format__ (__printf__, 3, 4)));
+ int shareHostSocket(Stream& other_stream);
Review Comment:
share大写开头
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -266,7 +273,7 @@ void SendRpcResponse(int64_t correlation_id,
// Response_stream can be INVALID_STREAM_ID when error occurs.
if (SendStreamData(sock, &res_buf,
accessor.remote_stream_settings()->stream_id(),
- accessor.response_stream()) != 0) {
+ accessor.response_streams()[0]) != 0) {
Review Comment:
有没有可能数组越界？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
