GreateCode commented on code in PR #2734:
URL: https://github.com/apache/brpc/pull/2734#discussion_r1712604036


##########
src/brpc/controller.cpp:
##########
@@ -344,6 +345,11 @@ void Controller::set_backup_request_ms(int64_t timeout_ms) 
{
     }
 }
 
+int64_t Controller::backup_request_ms() const {
+    return NULL != _backup_request_policy ?
+           _backup_request_policy->GetBackupRequestMs() : _backup_request_ms;
+}

Review Comment:
   这样用起来不方便。
   我觉得让cntl也可以设置policy就解决了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to