AnDiXL commented on code in PR #2710:
URL: https://github.com/apache/brpc/pull/2710#discussion_r1694447282


##########
tools/wireshark_baidu_std.lua:
##########
@@ -237,6 +275,8 @@ dissect_proto = function(tvbuf, pktinfo, root, offset)
                 method_name = protobuf_field_values[k].range:string(ENC_UTF8)
             elseif v.value == "correlation_id" then
                 correlation_id = protobuf_field_values[k].range:uint64()

Review Comment:
   > 这里的值也是错的, 只不过目前只是作为 key 来用,没影响。
   
   是的,这里其实跟attachment_size是一样的,如果需要拿到真实的correlation_id值,同样要经过le_uint & 
反序列化的操作,只是当前用不到



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to