[PR] fix h2 rpc_dump mem leak bug (brpc)

[via GitHub]

GreateCode opened a new pull request, #2661:
URL: https://github.com/apache/brpc/pull/2661

   ### What problem does this PR solve?
   
   Issue Number:
   
   Problem Summary:
   **h2 rpc_dump时 内存泄漏**。
   
   
具体是http和h2都走ProcessHttpRequest方法，在处理rpc_dump时，先AskToBeSampled创建堆对象再判is_http2，若是http2无释放堆对象逻辑。
   
   发压cmd：rpc_press -protocol=h2 xxxx
   
   ### What is changed and the side effects?
   Changed:
   h2 req不做AskToBeSampled
   
   修复前：
   
![image](https://github.com/apache/brpc/assets/9795716/2c37f39a-4282-42e4-b7bc-aae025bae5fc)
   
![image](https://github.com/apache/brpc/assets/9795716/37f56855-89be-42a0-9710-5909a6589288)
   
![image](https://github.com/apache/brpc/assets/9795716/35f679b4-a788-4600-98e3-d816b484a909)
   
![image](https://github.com/apache/brpc/assets/9795716/d7bc0f88-99f6-4e54-85ce-95c3a5a4e8fc)
   
   
[brpc_h2_rpc_dump_mem_leak_bug.pdf](https://github.com/user-attachments/files/15798428/brpc_h2_rpc_dump_mem_leak_bug.pdf)
   
   
   修复后：
   
![image](https://github.com/apache/brpc/assets/9795716/e826f4bb-1e84-408d-b452-579ad6d48bcb)
   
![image](https://github.com/apache/brpc/assets/9795716/ddb6b167-0ecf-4716-8dc4-9367a250c3fe)
   
![image](https://github.com/apache/brpc/assets/9795716/a2036e8f-2fa1-44da-8e5d-6078ab02cbce)
   
   
[brpc_h2_rpc_dump_mem_leak_fixed.pdf](https://github.com/user-attachments/files/15798432/brpc_h2_rpc_dump_mem_leak_fixed.pdf)
   
   
   Side effects:
   - Performance effects(性能影响):
   无
   - Breaking backward compatibility(向后兼容性): 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related 
tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of 
Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org