chenBright opened a new pull request, #2614:
URL: https://github.com/apache/brpc/pull/2614

   ### What problem does this PR solve?
   
   Issue Number:
   
   
https://github.com/apache/brpc/blob/6a335aa8bc713768aaa4dfcc5b1b2b66fe64e7a8/test/run_tests.sh#L37-L44
   
   
`run_tests.sh`中有问题,认为最新的core文件一定是失败的ut生成的,但是[ci](https://github.com/apache/brpc/actions/runs/8832477501/job/24249875410)中出现了对不上的情况:
   
   >  1 FAILED TEST
   corefile=./core.test_butil.8086 prog=brpc_grpc_protocol_unittest
   
   Problem Summary:
   
   ### What is changed and the side effects?
   
   Changed:
   
   在core文件名称包含pid时,将pid作为查找条件之一。
   
   Side effects:
   - Performance effects(性能影响):
   
   - Breaking backward compatibility(向后兼容性): 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related 
tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of 
Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to