chenBright commented on code in PR #2411:
URL: https://github.com/apache/brpc/pull/2411#discussion_r1356567999
##########
src/brpc/builtin/rpcz_service.cpp:
##########
@@ -56,6 +56,22 @@ inline std::ostream& operator<<(std::ostream& os, const Hex&
h) {
return os;
}
+static std::string EscapeXSS(const std::string& data) {
Review Comment:
https://github.com/apache/brpc/blob/72036f14cc4f25843fcc324599c6041d2cd30d38/src/brpc/controller.cpp#L1381-L1393
WebEscape已经实现了同样的功能，应该不用重新实现？
##########
src/brpc/builtin/rpcz_service.cpp:
##########
@@ -56,6 +56,22 @@ inline std::ostream& operator<<(std::ostream& os, const Hex&
h) {
return os;
}
+static std::string EscapeXSS(const std::string& data) {
Review Comment:
https://github.com/apache/brpc/blob/72036f14cc4f25843fcc324599c6041d2cd30d38/src/brpc/controller.cpp#L1381-L1393
WebEscape已经实现了同样的功能，应该不用重新实现？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
