wwbmmm commented on code in PR #2210:
URL: https://github.com/apache/brpc/pull/2210#discussion_r1199880559
##########
src/brpc/server.h:
##########
@@ -560,10 +565,14 @@ class Server {
int Concurrency() const {
return butil::subtle::NoBarrier_Load(&_concurrency);
};
-
+
// Returns true if accept request, reject request otherwise.
bool AcceptRequest(Controller* cntl) const;
+ bool HasProgressiveReadMethod() const {
Review Comment:
简单的getter/setter函数，用下划线分隔的全小写命名方式
##########
test/brpc_http_rpc_protocol_unittest.cpp:
##########
@@ -1137,7 +1137,7 @@ TEST_F(HttpTest,
server_end_read_short_body_progressively) {
}
TEST_F(HttpTest, server_end_read_failed) {
- const int port = 8923;
+ const int port = 8923;
Review Comment:
缩进不对
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
