wayslog opened a new pull request, #1965: URL: https://github.com/apache/incubator-brpc/pull/1965
### What problem does this PR solve? Issue Number: #1911 Problem Summary: hostname2endpoint implement not compatite with domain RFCs. ### What is changed and the side effects? Changed: change the buf length as 256, and use MAX_DOMAIN_LENGTH to check the domain name valid. But I don't have an exists domain to test it. Side effects: - Performance effects(性能影响): hostname2endpoint will allocate more 192 byte memory in stack. - Breaking backward compatibility(向后兼容性): yes --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
