0x2Adr1 commented on PR #1657:
URL: https://github.com/apache/incubator-brpc/pull/1657#issuecomment-1232985061
Looks like I am coming a few minutes too late after the merge! There is a
slight change to be made to make it work with Mac M1:
```
--- BUILD.bazel
+++ BUILD.bazel
@@ -48,7 +48,7 @@ LINKOPTS = [
"-pthread",
"-ldl",
] + select({
- "@bazel_tools//tools/osx:darwin": [
+ "@platforms//os:macos": [
"-framework CoreFoundation",
"-framework CoreGraphics",
"-framework CoreData",
@@ -206,7 +206,7 @@ BUTIL_SRCS = [
"src/butil/recordio.cc",
"src/butil/popen.cpp",
] + select({
- "@bazel_tools//tools/osx:darwin": [
+ "@platforms//os:macos": [
"src/butil/time/time_mac.cc",
"src/butil/mac/scoped_mach_port.cc",
],
@@ -322,7 +322,7 @@ cc_library(
"//bazel/config:brpc_with_glog": ["@com_github_google_glog//:glog"],
"//conditions:default": [],
}) + select({
- "@bazel_tools//tools/osx:darwin": [":macos_lib"],
+ "@platforms//os:macos": [":macos_lib"],
"//conditions:default": [],
}),
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
