[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

Sat, 28 Aug 2021 02:40:50 -0700 


guodongxiaren commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907601489


   已经根据反馈修改了代码。有几个地方和你确认一下。
   1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://` 
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
   2. 当前的实现如果初始化的URL中是机器IP，调用ParseHostname（间接调用hostname2ip）也会解析成功，最后把ip存到 
_hostname中，不知道是否需要额外规避掉这种情况，让 _hostname只存储主机名或者网络域名？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to