jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354712253
##########
File path: src/brpc/redis_reply.h
##########
@@ -56,6 +59,13 @@ class RedisReply {
bool is_string() const; // True if the reply is a string.
bool is_array() const; // True if the reply is an array.
+ bool SetNilString(); // "$-1\r\n"
Review comment:
零注释。你当然觉得这是让这个reply变成对应的内容，但用户并不会，而且用户也不清楚多次调用会发生什么，本质上是换位思考能力。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
