gydong commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268414967
##########
File path: src/brpc/socket.cpp
##########
@@ -1026,6 +1125,9 @@ bool HealthCheckTask::OnTriggeringTask(timespec*
next_abstime) {
}
ptr->Revive();
ptr->_hc_count = 0;
+ if (ptr->IsHealthCheckingUsingRPC()) {
Review comment:
这块逻辑感觉有点不连贯。为什么不是在revive函数中直接StartCheck，并在StartCheck中设置_health_checking_using_rpc？现在的实现，此处
IsHealthCheckingUsingRPC 的语义更像是NeedHealthCheckingUsingRPC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
