TousakaRin commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268080437
##########
File path: src/brpc/socket.cpp
##########
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+ if (FLAGS_health_check_using_rpc) {
Review comment:
这里似乎有问题，在compare_exchange_weak成功之后，lb就已经能够选取之前SetFailed的socket了，之后设置state为heath_checking_using_rpc，中间会导致有一些预期之外的指向SetFailed节点的rpc。这个问题在这里还好，由于上面的sp->circuit_breaker.Reset()；也存在类似问题，有小概率导致熔断无法恢复。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
