+1 (binding) * reviewed release notes * spot checked repository * ran bk from packaged binaries * built from packaged sources ** builds ok with jdk 17 ** build error with jdk 21. This happens on master too, but I think this is NOT the release stopper. I added https://github.com/apache/bookkeeper/issues/4189 to address later
On Thu, Jan 18, 2024 at 6:08 PM Hang Chen <chenh...@apache.org> wrote: > Hi everyone, > Please review and vote on the release candidate #0 for version 4.16.4, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed > to dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.16.4-rc0" [4] with git sha [5] > > BookKeeper's KEYS file contains the PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review the maven repo, release tag, licenses, and any other things > you think it is important to release. > > The vote will be open for at least 72 hours. It is adopted by the > majority approval, with at least 3 PMC affirmative votes. > > Thanks, > Release Manager > > [1] https://github.com/apache/bookkeeper/pull/4182/files > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.4-rc0/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1091 > [4] https://github.com/apache/bookkeeper/tree/v4.16.4-rc0 > [5] 16de712d8c8f1f0296697331bb68c1ad0eb5787d > -- Andrey Yegorov
