I found the license has problems as well.

Close this vote and I will send a new vote for the release.

On Thu, 18 Aug 2022 at 09:13, Yong Zhang <zhangyong1025...@gmail.com> wrote:

> I want to revert the change in our release to unblocking the release
> process.
> Then we fix the failed test and CI in the master branch.
>
> What do you think?
>
> On Thu, 18 Aug 2022 at 09:11, Yong Zhang <zhangyong1025...@gmail.com>
> wrote:
>
>> Enrico,
>>
>> It passed in the CI.
>>
>> I just found there have failed tests but the CI shows passed.
>>
>> https://github.com/apache/bookkeeper/runs/7664698921?check_suite_focus=true
>>
>> Looks like our CI has something wrong.
>>
>> The same thing happened in this PR
>> https://github.com/apache/bookkeeper/pull/3310
>> The TLS tests failed but the CI shows passed.
>>
>>
>>
>> On Thu, 18 Aug 2022 at 01:27, steven lu <lushiji2...@gmail.com> wrote:
>>
>>> As for why the testcase run failed,it's caused by   [Client] Switch to
>>> rely
>>> on Netty for Hostname Verification (#3310)
>>> https://github.com/apache/bookkeeper/pull/3310,
>>> we can revert pr: 3310 or fix the bug on version 4.15.1
>>>
>>> Enrico Olivelli <eolive...@gmail.com> 于2022年8月16日周二 21:56写道:
>>>
>>> > Yong,
>>> > thanks for driving the release
>>> >
>>> > I am still validating the release, I want to share this finding.
>>> > TestTLS is failing on my machine.
>>> >
>>> > Is the test passing locally on your machine ?
>>> >
>>> > I see the same error on branch-4.14 on CI.
>>> >
>>> > Maybe there is some problem with TLS ?
>>> >
>>> > [ERROR] TestTLS.testConnectToLocalTLSClusterTLSClient  Time elapsed:
>>> > 13.708 s  <<< ERROR!
>>> > org.apache.bookkeeper.client.BKException$BKNotEnoughBookiesException:
>>> > Not enough non-faulty bookies available
>>> > at
>>> >
>>> org.apache.bookkeeper.client.SyncCallbackUtils.finish(SyncCallbackUtils.java:83)
>>> > at
>>> >
>>> org.apache.bookkeeper.client.SyncCallbackUtils$SyncAddCallback.addComplete(SyncCallbackUtils.java:251)
>>> > at
>>> >
>>> org.apache.bookkeeper.client.AsyncCallback$AddCallback.addCompleteWithLatency(AsyncCallback.java:92)
>>> > at
>>> >
>>> org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:431)
>>> > at
>>> >
>>> org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1813)
>>> > at
>>> >
>>> org.apache.bookkeeper.client.LedgerHandle$5.safeRun(LedgerHandle.java:575)
>>> >
>>> > Il giorno ven 5 ago 2022 alle ore 03:31 steven lu
>>> > <lushiji2...@gmail.com> ha scritto:
>>> > >
>>> > > +1, Approve the release
>>> > > look good to me
>>> > >
>>> > > Yong Zhang <zhangyong1025...@gmail.com> 于2022年8月4日周四 20:39写道:
>>> > >
>>> > > > Hi everyone,
>>> > > > Please review and vote on the release candidate #1 for the version
>>> > 4.15.1,
>>> > > > as follows:
>>> > > > [ ] +1, Approve the release
>>> > > > [ ] -1, Do not approve the release (please provide specific
>>> comments)
>>> > > >
>>> > > > The complete staging area is available for your review, which
>>> includes:
>>> > > > * Release notes [1]
>>> > > > * The official Apache source and binary distributions to be
>>> deployed to
>>> > > > dist.apache.org [2]
>>> > > > * All artifacts to be deployed to the Maven Central Repository [3]
>>> > > > * Source code tag "v4.15.1-rc0" [4] with git sha [5]
>>> > > >
>>> > > > BookKeeper's KEYS file contains PGP keys we used to sign this
>>> release:
>>> > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>> > > >
>>> > > > Please download these packages and review this release candidate:
>>> > > >
>>> > > > - Review release notes
>>> > > > - Download the source package (verify shasum, and asc) and follow
>>> the
>>> > > > instructions to build and run the bookkeeper service.
>>> > > > - Download the binary package (verify shasum, and asc) and follow
>>> the
>>> > > > instructions to run the bookkeeper service.
>>> > > > - Review maven repo, release tag, licenses, and any other things
>>> you
>>> > think
>>> > > > it is important to a release.
>>> > > >
>>> > > > The vote will be open for at least 72 hours. It is adopted by
>>> majority
>>> > > > approval, with at least 3 PMC affirmative votes.
>>> > > >
>>> > > > Thanks,
>>> > > > Release Manager
>>> > > >
>>> > > > [1]
>>> > > >
>>> > > >
>>> >
>>> https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53
>>> > > > [2]
>>> > > >
>>> >
>>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc0/
>>> > > > [3]
>>> > > >
>>> > > >
>>> >
>>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1067/
>>> > > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc0
>>> > > > [5] ca082ed96cea8d4d013aaf15ee8fd1eb4065df83
>>> > > >
>>> >
>>>
>>

Reply via email to