I found out that Spotbugs check doesn't pass. With an unlucky combination, the configuration has changed and we only check for warnings with level=High (since when we migrated CI to gradle, I believe it was unintended) The story in short: - Spotbugs on jdk11 has always been disabled - We migrated CI to gradle with a different configuration - New warnings happened but silently ignored - We migrated CI to jdk11 - We migrated back to maven but keeping jdk11 as default jdk (and then spotbugs not enabled) - branch-4.14 is still with JDK8 CI
I sent a PR to fix it on the master branch. we should apply it to branch-4.14 and maybe 4.15 (?). I've seen the problem because I've created a pull against 4.14 and the CI failed Pull: https://github.com/apache/bookkeeper/pull/3160 Luckily I don't see critical issues. If we are not confident to cherry-pick this pull before cutting the release, I'm okay to go ahead with 4.14.5 without these changes. Let me know what you think BR, Nicolò Boschi Il giorno mer 30 mar 2022 alle ore 14:06 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Il giorno mer 30 mar 2022 alle ore 13:52 Nicolò Boschi > <boschi1...@gmail.com> ha scritto: > > > > I'd love to do that if it's okay for you > > Sure > Thank you > > Ping me if you need any help > > Enrico > > > > > Nicolò Boschi > > > > > > Il giorno gio 24 mar 2022 alle ore 09:25 Enrico Olivelli < > > eolive...@gmail.com> ha scritto: > > > > > Hello, > > > we have a fix for a bad bug that may cause data corruption. > > > https://github.com/apache/bookkeeper/pull/3110 > > > > > > I have cherry-picked it to branch-4.14. > > > Any volunteers for a release ? > > > > > > Enrico > > > >
