Please review: https://github.com/apache/bookkeeper/pull/3130 It is easier to review change-by-change than all files.
It builds locally but I haven't run the tests. I probably missed something related to CI. On Mon, Mar 21, 2022 at 5:42 PM Yong Zhang <zhangyong1025...@gmail.com> wrote: > +1. > > Next time when we migrate to the Gradle, I think we may need to keep both > Maven > and Gradle for a while, until the Gradle build is stable, then we remove > the Maven build. > > On Tue, 22 Mar 2022 at 00:41, Andrey Yegorov <andrey.yego...@datastax.com> > wrote: > > > +1. > > > > My attempts to dry run the release with gradle didn't succeed so far. > > We still have one PR pending for the release 4.15 > > https://github.com/apache/bookkeeper/pull/3110 > > but I think we'll have high chance of success if we go with maven for > 4.15. > > > > I can try restoring the deleted maven build + fix what was added without > > maven. > > After that we can switch CI to maven. > > > > > > On Mon, Mar 21, 2022 at 6:31 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > I see that the source tarball has a wrong name in current master > > > > > > I filed this issue, I believe it is a problem for a release > > > https://github.com/apache/bookkeeper/issues/3129 > > > > > > I am also facing other problems with the Gradle build here > > > https://github.com/apache/bookkeeper/pull/3084 > > > I am not able to exclude LogBack and some Netty modules imported by > > > ZooKeeper, > > > I see that we are importing dependencies using "dependency.create" and > > > I don't find much documentation about this. > > > > > > When I build locally BK I see many warnings from Gradle, like: > > > "Expiring Daemon because JVM heap space is exhausted" or > > > or > > > > > > Gradle detected a problem with the following location: > > > > > > > > > '/Users/enrico.olivelli/dev/bookkeeper/bookkeeper-dist/build/distributions/bookkeeper-4.15.0-SNAPSHOT-src-bin.tar.gz'. > > > Reason: Task ':bookkeeper-dist-src:distTarSha512' uses this output of > > > task ':bookkeeper-dist:distTar' without declaring an explicit or > > > implicit dependency. This can lead to incorrect results being > > > produced, depending on what order the tasks are executed > > > > > > > > > This Gradle migration is basically blocking the release and we are very > > > late. > > > > > > IIUC there was some part of the community who pushed hard to do this > > > migration, but all the enthusiasm seems to have gone away and now we > > > have a broken repository. > > > > > > I wonder if it would be better to roll back to Maven, we didn't > > > refactor the repository and restoring the pom.xml files may not be so > > > hard as fixing all the Gradle problems. > > > > > > > > > > > > > > > Enrico > > > > > > > > > -- > > Andrey Yegorov > > > -- Andrey Yegorov
