Thank you for sharing your patch. I left some feedback on the PR We need more eyes on the patch, it is a interesting work but it is a big patch
Enrico Il giorno gio 10 mar 2022 alle ore 10:09 Yuri Mizushima <yumiz...@yahoo-corp.jp> ha scritto: > > Any thoughts on this PR? > > Regards, > -- > Yuri Mizushima > yumiz...@yahoo-corp.jp > > > On 2022/02/21 19:40, "Yuri Mizushima" <yumiz...@yahoo-corp.jp> wrote: > > Dear BookKeeper community, > > I've created the PR of enhancement. I want to add a ledger relocation feature > adhering to the ensemble placement policy. > https://github.com/apache/bookkeeper/pull/2931 > > In my understanding, we can get "not adhering" ledgers from log output. > https://github.com/apache/bookkeeper/blob/release-4.14.4/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java#L1329-L1446 > However, we can't recover the ensemble which isn't adhering to the placement > policy directly. > > I'll add the new bookkeeper shell command for the relocation feature in this > PR. > I think the next step is asynchronous relocation, like the auto-recovery > feature. > > Could you please take a look? (Feel free to ask me any questions or > suggestions, etc.) > > Regards, > -- > Yuri Mizushima > yumiz...@yahoo-corp.jp
