+1 (non-binding) * Verified checksums/signatures * Built from source on JDK11 * Verified that https://github.com/apache/bookkeeper/issues/2854 has already been fixed * Ran simpletest by localbookie
Thank you for handling my comments. Regards, -- Yuri Mizushima yumiz...@yahoo-corp.jp On 2021/11/06 11:47, "Hang Chen" <chenh...@apache.org> wrote: +1 (non-binding) Verified: * Checksums * Build from source with JDK 11 on Ubuntu 20.04 * Run BookKeeper Cluster along with Pulsar 2.8.1 and run pulsar-perf to test read and write. Thanks, Hang Matteo Merli <mme...@apache.org> 于2021年11月6日周六 上午4:52写道： > > +1 > > Verified: > * Checksums > * Building > * Starting standalone bookie > > > -- > Matteo Merli > <mme...@apache.org> > > On Fri, Nov 5, 2021 at 4:26 AM Enrico Olivelli <eolive...@gmail.com> wrote: > > > > +1 (binding) > > > > - verified signatures and digests > > - built from source, on JDK8 + Ubuntu > > - verified Apache RAT check > > - run single machine cluster smoke tests > > - run unit tests > > > > > > Some notes: > > - tests do no pass on JDK11, we are already working on this > > - I found one flaky test, this is a fix > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Fpull%2F2881&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7Cd5f2982d6e564c5eb9f608d9a0cfbfdd%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637717636401260153%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pb4VsYpLvweEW63SmSyl7355xM%2BoN4aocRaOvC45Wts%3D&reserved=0 > > > > Thank you very much for being the Release Manager Yong! > > > > Enrico Olivelli > > > > > > Il giorno mar 2 nov 2021 alle ore 11:14 Yong Zhang <y...@apache.org> ha > > scritto: > > > > > Hi everyone, > > > Please review and vote on the release candidate #0 for the version 4.14.3, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.14.3-rc2" [4] with git sha [5] > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Fbookkeeper%2FKEYS&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7Cd5f2982d6e564c5eb9f608d9a0cfbfdd%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637717636401260153%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Ig18%2FqHHqh%2FkFwH7N2WOuQH%2B5ajYDC7jc9GdANv1N3c%3D&reserved=0 > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Fpull%2F2864%2Ffiles%23diff-5405f1e88785133938fb03ee37380c8df913b3cbaec94a2d9bfcda1f8bd57cd5&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7Cd5f2982d6e564c5eb9f608d9a0cfbfdd%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637717636401260153%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Btn3I17%2FB8la2UMPVsRlU3Wi4BafWO2RpXokZJM9hZM%3D&reserved=0 > > > [2] > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fbookkeeper%2Fbookkeeper-4.14.3-rc2%2F&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7Cd5f2982d6e564c5eb9f608d9a0cfbfdd%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637717636401260153%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=PNYZNKu8h2RKVJ9Iz55hHAzArcIMv79eh2FWjEaRRKc%3D&reserved=0 > > > [3] > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachebookkeeper-1060&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7Cd5f2982d6e564c5eb9f608d9a0cfbfdd%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637717636401260153%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dwOaZe16JVIm9%2BN%2BMViKXPCWYjKIPUVxRC5y9G9Yvr4%3D&reserved=0 > > > [4] > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fbookkeeper%2Freleases%2Ftag%2Fv4.14.3-rc2&data=04%7C01%7Cyumizush%40yahoo-corp.jp%7Cd5f2982d6e564c5eb9f608d9a0cfbfdd%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637717636401260153%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZhiubAlSnkE%2FXj9r2miwRUPhWPhVppY2xJzZJRRtRaI%3D&reserved=0 > > > [5] 32f9cd7d5ce73cc0f29c7e66ce5adc0e6640d222 > > >
