+1 (binding) Built from sources Run test from sources Basic verifications
Thanks for driving the release Enrico Il Lun 17 Mag 2021, 20:53 Sijie Guo <guosi...@gmail.com> ha scritto: > +1 (binding) > > All things below are good. > > * Signatures > * Source package structure, and compile > * Binary package > * Running standalone bookie and client > > On Mon, May 17, 2021 at 9:43 AM Matteo Merli <mme...@apache.org> wrote: > > > +1 (binding) > > > > Checked: > > * Signatures > > * Source package structure, and compile > > * Binary package > > * Running standalone bookie and client > > > > > > -- > > Matteo Merli > > <mme...@apache.org> > > > > On Fri, May 14, 2021 at 2:23 PM Andrey Yegorov > > <andrey.yego...@datastax.com> wrote: > > > > > > I do not hear voices against it so I assume everyone is ok with this. > > > (I started building RC1 and docker hanged mid-process; happy to not > deal > > > with retry). > > > > > > The vote has been out for about 5 days already. > > > I need votes from 3 PMCs to proceed. > > > > > > > > > On Fri, May 14, 2021 at 12:10 PM Henry Saputra < > henry.sapu...@gmail.com> > > > wrote: > > > > > > > I am +1 to keep Gradle out from this release since the files are ok > > not to > > > > be included. > > > > > > > > I am ok to keep RC0 for 4.14.0 for VOTE as release candidate. > > > > > > > > - Henry > > > > > > > > On Fri, May 14, 2021 at 12:14 AM Enrico Olivelli < > eolive...@gmail.com> > > > > wrote: > > > > > > > > > Andrey, > > > > > I have merged the patch. > > > > > > > > > > In my opinion the source tarball should reflect the git repo > without > > > > > the '.git' database. > > > > > That said, the most important thing is that the source release > > > > > contains the files to build the project and produce working > binaries. > > > > > > > > > > This is in the spirit of Open Source (of the ASF at least), you can > > > > > pick the sources, modify them, build and run the new binaries. > > > > > > > > > > AFAIK The Gradle build is not fully implemented so it is not so > > > > > important to see those files at the moment > > > > > I agree that we can strip away the website, it is useless to the > > > > > purpose of building the project. > > > > > > > > > > Enrico > > > > > > > > > > > > > > > Il giorno gio 13 mag 2021 alle ore 23:43 Andrey Yegorov > > > > > <andrey.yego...@datastax.com> ha scritto: > > > > > > > > > > > > I looked at the situation with src release artifact, and: > > > > > > - it was definitely built from the right changelist (I spot > checked > > > > some > > > > > > files affected by the last commit) > > > > > > - site/ is explicitly excluded > > > > > > > > > > > > > > > > > > https://github.com/apache/bookkeeper/blob/732b6cf2a6576c844a4b43176125e82d500a6ea8/bookkeeper-dist/src/assemble/src.xml#L61 > > > > > > - site2 is not excluded (should be fixed) > > > > > > - gradle files are not explicitly included, pom are > > > > > > > > > > > > > > > > > > https://github.com/apache/bookkeeper/blob/732b6cf2a6576c844a4b43176125e82d500a6ea8/bookkeeper-dist/src/assemble/src.xml#L33 > > > > > > > > > > > > that src.xml is used to package the release artifacts > > > > > > > > > > > > > > > > > > https://github.com/apache/bookkeeper/blob/master/bookkeeper-dist/pom.xml#L55 > > > > > > > > > > > > It looks like the plugin resolves the situation with the file not > > > > > matching > > > > > > includes and excludes by excluding it. > > > > > > > > > > > > PR that adds gradle into the includes patterns and excludes > site2: > > > > > > https://github.com/apache/bookkeeper/pull/2714 > > > > > > > > > > > > I can either rebuild the RC or we can decide to proceed. > > > > > > Gradle was not used to build/release 4.14.0 > > > > > > > > > > > > > > > > > > On Thu, May 13, 2021 at 8:34 AM Andrey Yegorov < > > > > > andrey.yego...@datastax.com> > > > > > > wrote: > > > > > > > > > > > > > I ran the release script, as described in the release > procedure. > > > > > > > It all ran from the docker container. > > > > > > > > > > > > > > On Wed, May 12, 2021 at 11:30 PM Henry Saputra < > > > > > henry.sapu...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > >> Hi Andrey, > > > > > > >> > > > > > > >> How did you generate the source release artifact? Looks like > it > > is > > > > > missing > > > > > > >> some files like the site directory and the gradle build files. > > > > > > >> > > > > > > >> - Henry > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> On Sun, May 9, 2021 at 11:16 PM Andrey Yegorov < > > > > > > >> andrey.yego...@datastax.com> > > > > > > >> wrote: > > > > > > >> > > > > > > >> > Hi everyone, > > > > > > >> > Please review and vote on the release candidate #0 for the > > version > > > > > > >> 4.14.0, > > > > > > >> > as follows: > > > > > > >> > [ ] +1, Approve the release > > > > > > >> > [ ] -1, Do not approve the release (please provide specific > > > > > comments) > > > > > > >> > > > > > > > >> > The complete staging area is available for your review, > which > > > > > includes: > > > > > > >> > * Release notes [1] > > > > > > >> > * The official Apache source and binary distributions to be > > > > > deployed to > > > > > > >> > dist.apache.org [2] > > > > > > >> > * All artifacts to be deployed to the Maven Central > > Repository [3] > > > > > > >> > * Source code tag "release-4.14.0" [4] with git sha > > > > > > >> > 4729682f00f05f23a1821211cbce064e653edb83 > > > > > > >> > > > > > > > >> > BookKeeper's KEYS file contains PGP keys we used to sign > this > > > > > release: > > > > > > >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > >> > > > > > > > >> > Please download these packages and review this release > > candidate: > > > > > > >> > > > > > > > >> > - Review release notes > > > > > > >> > - Download the source package (verify shasum, and asc) and > > follow > > > > > the > > > > > > >> > instructions to build and run the bookkeeper service. > > > > > > >> > - Download the binary package (verify shasum, and asc) and > > follow > > > > > the > > > > > > >> > instructions to run the bookkeeper service. > > > > > > >> > - Review maven repo, release tag, licenses, and any other > > things > > > > you > > > > > > >> think > > > > > > >> > it is important to a release. > > > > > > >> > > > > > > > >> > The vote will be open for at least 72 hours. It is adopted > by > > > > > majority > > > > > > >> > approval, with at least 3 PMC affirmative votes. > > > > > > >> > > > > > > > >> > Thanks, > > > > > > >> > Release Manager > > > > > > >> > > > > > > > >> > [1] https://github.com/apache/bookkeeper/pull/2712 > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > https://github.com/apache/bookkeeper/blob/4f88ae1bf271d025945437e8499955118000ce29/site/docs/4.14.0/overview/releaseNotes.md > > > > > > >> > > > > > > > >> > [2] > > > > > > >> > > > > > > > >> > > > > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.14.0-rc0/ > > > > > > >> > > > > > > > >> > [3] > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1052/ > > > > > > >> > > > > > > > >> > [4] > https://github.com/apache/bookkeeper/commits/branch-4.14 > > @ > > > > sha > > > > > > >> 4729682 > > > > > > >> > > > > > > > >> > -- > > > > > > >> > Andrey Yegorov > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > -- > > > > > > > Andrey Yegorov > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > -- > > > > > > Andrey Yegorov > > > > > > > > > > > > > > > > > > -- > > > > > > -- > > > Andrey Yegorov > > >
