+1 - Build source on Mac 10.15.7, with JDK1.8 - Test the explicit lac work well with query the last message with pulsar-sql.
Yong On Fri, 13 Nov 2020 at 02:36, Sijie Guo <guosi...@gmail.com> wrote: > +1 (binding) > > - Both source package and binaries are good. > - Test compiling the source package. > - Tags and license are good > > - Sijie > > On Thu, Nov 12, 2020 at 2:17 AM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > +1 (binding) > > - Build sources on Mac, with JDK14 > > - Tested the built sources, run a few smoke tests with JDK14 > > - tested bookieId on a small cluster > > > > I noticed a small issue on "bookkeper standalone" mode, that is not > > implementing BP-38 correctly and thus you cannot use BookieId, but > > "bookkeeper standalone" is mostly a dev mode utility, so not a big deal, > > I have already raised a PR to fix it > > > > Enrico > > > > Il giorno mer 11 nov 2020 alle ore 16:47 Jia Zhai <zhai...@apache.org> > ha > > scritto: > > > > > Hi everyone, > > > Please review and vote on release candidate #0 for version 4.12.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.12.0-rc0" [4] with git sha > > > dcf6bea03610fb69663cd8468a034b8a3823214e > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by the > > majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Jia > > > > > > [1] https://github.com/apache/bookkeeper/pull/2478 > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.12.0-rc0/ > > > [3] > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1049 > > > [4] https://github.com/apache/bookkeeper/tree/v4.12.0-rc0 > > > > > >
