Jia,
I have amended my commit of yesterday that you committed.
There was a typo in the script

Now Docker autobuild was able to build the 'latest' tag

Enrico

Il giorno mar 20 ott 2020 alle ore 08:38 <eolive...@apache.org> ha scritto:

> This is an automated email from the ASF dual-hosted git repository.
>
> eolivelli pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 01214aa  Issue 2445: Builds of Docker tag bookkeeper:latest are
> failing (#2446)
> 01214aa is described below
>
> commit 01214aa6d02ce55e4d20f47179b5e53c32617e85
> Author: Enrico Olivelli <enrico.olive...@diennea.com>
> AuthorDate: Tue Oct 20 08:34:35 2020 +0200
>
>     Issue 2445: Builds of Docker tag bookkeeper:latest are failing (#2446)
> ---
>  docker/hooks/build | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/docker/hooks/build b/docker/hooks/build
> index f245083..653f5df 100755
> --- a/docker/hooks/build
> +++ b/docker/hooks/build
> @@ -1,9 +1,8 @@
>  #!/bin/bash
> -
>  # When we build 'latest' tag we want to not override BK_VERSION variable
> -if [[ $DOCKER_TAG = "latest" ]]
> +if [[ "$DOCKER_TAG" = "latest" ]]
>  then
> -  docker build --build-arg -t $IMAGE_NAME .
> +  docker build -t $IMAGE_NAME .
>  else
>    docker build --build-arg BK_VERSION=$DOCKER_TAG -t $IMAGE_NAME .
>  fi
>
>

Reply via email to