+1 (binding) - verified checksums and signatures - built source package with JDK8 on Fedora, all tests passed - performed a few smoke tests with built binaries, on JDK8, only one comment (see below) - built and run tests of HerdDB, all passed, only one comment (see below) - build and run Java tests of https://pravega.io all tests passed
Thank you very much Rajan for putting this all together ! Best regards Enrico Problem 1, bkctl, non blocker: "bkctl" does not work on JDK14, this is due to deprecated and removed command line options. The fix is trivial, just fix the bash scripts Problem 2, HerdDB, non blocker HerdDB is able to boot a Bookie, using a Java unofficial API (BookieServer). The signature of the constructor changed due to BP-38, the fix on HerdDB EmbeddedBookie is straightforward, just add BookieServiceInfo.NO_INFO as third parameter. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project herddb-core: Compilation failure [ERROR] /data/dev/herddb/herddb-core/src/main/java/herddb/cluster/EmbeddedBookie.java:[146,24] no suitable constructor found for BookieServer(org.apache.bookkeeper.conf.ServerConfiguration,org.apache.bookkeeper.stats.StatsLogger) [ERROR] constructor org.apache.bookkeeper.proto.BookieServer.BookieServer(org.apache.bookkeeper.conf.ServerConfiguration) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.bookkeeper.proto.BookieServer.BookieServer(org.apache.bookkeeper.conf.ServerConfiguration,org.apache.bookkeeper.stats.StatsLogger,java.util.function.Supplier<org.apache.bookkeeper.discover.BookieServiceInfo>) is not applicable [ERROR] (actual and formal argument lists differ in length) Il giorno mar 30 giu 2020 alle ore 06:17 Anup Ghatage <ghat...@gmail.com> ha scritto: > LGTM! > > non-binding +1 > > On Mon, Jun 29, 2020 at 8:56 PM Rajan Dhabalia <rdhaba...@apache.org> > wrote: > > > Hi everyone, > > > > Please review and vote on the release candidate #0 for the version > 4.11.0, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "release-4.11.0" [4] with git sha > > ceb140ba0bcab72ac3d22e7ace7712cea30bdfe9 > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you > think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Rajan > > > > [1] Release note: > > > > > https://github.com/apache/bookkeeper/pull/2361/commits/33c9be73d6d9ec2e58325f310076bbe5960cb8d0 > > in PR: https://github.com/apache/bookkeeper/pull/2361 > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.11.0-rc0/ > > [3] > > > > > https://repository.apache.org/content/repositories/staging/org/apache/bookkeeper/ > > [4] https://github.com/apache/bookkeeper/tree/v4.11.0-rc0 > > > > > -- > Anup Ghatage > www.ghatage.com >
