Anup Il Ven 12 Giu 2020, 03:22 Rajan Dhabalia <rdhaba...@apache.org> ha scritto:
> Thank you Anup for summarizing everything here. And Yes, I can drive 4.11 > release and we can start the process soon once we agree with all the > changes. > > I have already taken care of [bookie-shell] Add cmd to change > bookie-address into ledger metadata > <https://github.com/apache/bookkeeper/pull/2321> > > And if we think Avoid using directBuffer directly > <https://github.com/apache/bookkeeper/pull/2158> is risky at this point > then we can push to the next release. > > So, we can wait for Update ServerConfiguration to use ConfigKey and > ConfigKeyGroup <https://github.com/apache/bookkeeper/pull/1893> to be > merged and then we can start the release process soon. > > Thanks, > Rajan > > > > On Thu, Jun 11, 2020 at 8:49 AM Anup Ghatage <ghat...@gmail.com> wrote: > > > Sounds good Enrico. > > > > What do you think about the later sections I made? > > > > > > > *Push to next release and Add help wanted label* > > I see lots of new interest in the community and I think we should > > encourage it by adding these tags and letting the folks know that these > are > > achievable fixes without too much baggage. > Good > > > > *Push to next release* > > The next time we have a community meeting, I wish we can have some meeting. Enrico perhaps a good idea to bring > > these up and evaluate if we even need some of these as they're super old > > and architecture has changed since then. So we might not even need some > of > > them now. > Good Enrico > > > Overall I think we should undertake the cleaning of the issues / PR's > > section from what I've mentioned in the lists to start with at least. > > So we can weed out the old inactive ones which we won't/can't be working > > on. It would put us in a much better place for the next releases. > > > > Regards, > > Anup > > > > On Thu, Jun 11, 2020 at 1:26 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > >> Anup > >> thanks for bringing this to the attention. > >> great work ! > >> > >> I would like to see 4.11 out soon. > >> Rajan already told me he is interested in driving the release as soon as > >> he has cycles. > >> I can backup in case he has no time within the end of the month > >> > >> some comments below > >> Enrico > >> > >> > >> Il giorno gio 11 giu 2020 alle ore 04:44 Anup Ghatage < > ghat...@gmail.com> > >> ha scritto: > >> > >>> > >>> Hi Bookies! > >>> > >>> [image: image.png] > >>> > >>> > >>> > >>> We've seen awesome contributions since 4.10 but now we're considering > if > >>> it's time for 4.11. > >>> I've made a list of the tasks we had marked for our 4.11 milestone. I > >>> have separated them as ready to merge and push to next release based > on: > >>> > >>> - Last activity > >>> - Remaining work required for completion > >>> - Amount of conflicts since last change (hence might take more time > >>> to finish) > >>> > >>> PMC, Committers, Let's take a look at where we stand and if you feel > >>> these are substantial enough to ship. > >>> > >>> *Ready to merge, need to re-run a few tests.* > >>> - Avoid using directBuffer directly > >>> <https://github.com/apache/bookkeeper/pull/2158> > >>> > >> > >> This patch needs rebase and it is quite dangerous. I feel it is better > to > >> postone > >> > >> <https://github.com/apache/bookkeeper/pull/2158> > >>> > >>> - Update ServerConfiguration to use ConfigKey and ConfigKeyGroup > >>> <https://github.com/apache/bookkeeper/pull/1893> > >>> > >> I am ok but is needs a rebase from @Sijie Guo <guosi...@gmail.com> > >> > >>> > >>> - [bookie-shell] Add cmd to change bookie-address into ledger metadata > >>> <https://github.com/apache/bookkeeper/pull/2321> > >>> rerun integration tests, rest is ready. > >>> > >> > >> yes, it needs a little hand by Rajan > >> > >> > >>> > >>> - Add more more instructions for minorCompactionInterval in > >>> bookkeeper.conf <https://github.com/apache/bookkeeper/issues/2115> - > >>> Master issue > >>> -> PR with fix [conf] minorCompactionInterval should be greater than > >>> gcWaitTime <https://github.com/apache/bookkeeper/pull/2116> > >>> Can close this if we can merge above mentioned PR. Some tests are > >>> failing, need to re run them > >>> > >> > >> It is an old patch. I would prefer to postpone > >> > >> > >>> > >>> *Push to next release, partially completed* > >>> - Issue 1626: Add tests for > >>> LedgerUnderredplicationManager#markLedgerUnderreplicatedAsync > >>> <https://github.com/apache/bookkeeper/pull/1629> - Too many review > >>> comments to be addressed. > >>> - BP-33: Move releasing official docker images out of main repo > >>> <https://github.com/apache/bookkeeper/issues/1449> - This can be done > >>> after the release > >>> - Cookie should include index directory > >>> <https://github.com/apache/bookkeeper/issues/609> - Being worked on > but > >>> will change format of cookie. Best if pushed to next release. > >>> - use native fallocate & sync_file_range to improve journal allocation > >>> <https://github.com/apache/bookkeeper/issues/614> > >>> - BP-29: Metadata API module > >>> <https://github.com/apache/bookkeeper/issues/1123> - On the fence > about > >>> this one. 3/4 tasks are complete. The last task is to make all the > >>> remaining tests use the metadata service which I think aren't as many. > - > >>> Add help wanted label > >>> - BP-36: Stats documentation annotation > >>> <https://github.com/apache/bookkeeper/issues/1785> - Sijie, since we > >>> have all the code in place to use the annotation, can you elaborate on > >>> where the annotation should be used? Perhaps we can close this and you > can > >>> open a new issue for 4.12. OR we can simply push this out, fine with > that > >>> too. > >>> > >>> *Push to next release and Add help wanted label* > >>> - Bookie disk monitor should also monitor journal disks > >>> <https://github.com/apache/bookkeeper/issues/1349> - Not being worked > >>> on yet (OLD) - Add help wanted label > >>> - Improve asyncCreateFullPathOptimistic to reduce zookeeper verbose > >>> logging <https://github.com/apache/bookkeeper/issues/902> - Not being > >>> worked on yet (OLD) - Add help wanted label > >>> - incomplete fix for exception handling in flushRotatedLogs method and > >>> need of ConcurrentList for rotatedLogChannels > >>> <https://github.com/apache/bookkeeper/issues/1346> - Not being worked > >>> on yet (OLD) - Add help wanted label > >>> - Improve javadoc for public interfaces that takes user input > >>> <https://github.com/apache/bookkeeper/issues/757> - Not being worked > on > >>> yet (OLD) - Add help wanted label > >>> > >>> *Push to next release* > >>> - Don't allow write entries with same entry id multiple times in bookie > >>> <https://github.com/apache/bookkeeper/issues/1066> - Not being worked > >>> on yet (OLD) > >>> - In ReadOnlyLedgerHandle, metadata gets updated in the event of > >>> writeclose but lastAddConfirmed and length is not getting updated. > >>> <https://github.com/apache/bookkeeper/issues/594> - Not being worked > on > >>> yet. > >>> - Bookie ledger replication error lead to increased disk usage > >>> <https://github.com/apache/bookkeeper/issues/1908> - Not being worked > >>> on yet (OLD) > >>> - Needs to handle AuthFailed, SaslAuthenticated events > >>> <https://github.com/apache/bookkeeper/issues/284> - Not being worked > on > >>> yet (OLD) > >>> - Introduce BookieClusterManager and Improve BookieListener > >>> <https://github.com/apache/bookkeeper/issues/287> - Not being worked > on > >>> yet (OLD) > >>> - Bookie recovery should skip replicating empty ledgers. > >>> <https://github.com/apache/bookkeeper/issues/582> - Not being worked > on > >>> yet (OLD) > >>> - Split bookkeeper client into a separate maven module > >>> <https://github.com/apache/bookkeeper/issues/617> - Not being worked > on > >>> yet (OLD) > >>> - Package refactor on ledger storages > >>> <https://github.com/apache/bookkeeper/issues/622> - Not being worked > on > >>> yet (OLD) > >>> - Add checksumming for ledger index files > >>> <https://github.com/apache/bookkeeper/issues/626> - Not being worked > on > >>> yet (OLD) > >>> - BP-23: Ledger Balancer > >>> <https://github.com/apache/bookkeeper/issues/846> - Not being worked > on > >>> yet (OLD) > >>> - Sanity check on ledger storage type > >>> <https://github.com/apache/bookkeeper/issues/1159> - Not being worked > >>> on yet (OLD) > >>> - Add more test cases on LongZkLedgerIdGenerator > >>> <https://github.com/apache/bookkeeper/issues/901> - Not being worked > on > >>> yet (OLD) > >>> - remove old Codahale in package `org.apache.bookkeeper.stats` > >>> <https://github.com/apache/bookkeeper/issues/1262> - Not being worked > >>> on yet (OLD) > >>> > >>> > >>> -- > >>> Anup Ghatage > >>> www.ghatage.com > >>> > >> > > > > -- > > Anup Ghatage > > www.ghatage.com > > >