I am looking at a feature to disableEnsembleChanges
If the disableEnsembleChangeFeature
<https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java#L1856>
<https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java#L1856>is
available  it is calling unsetSuccessAndSendWriteRequest
<https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java#L1861>
without any ensemble changes, but the why are we calling
unsetSuccessAndSendWriteRequest, which is actually removing
<https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java#L237>
the Ack
and resending the write.
If there is an ensemble changes this makes sense but in this case ensemble
hasn't changed. Wondering if this is a bug/oversight.


Jvrao
---
First they ignore you, then they laugh at you, then they fight you, then
you win. - Mahatma Gandhi

Reply via email to