Precommit finished with success https://github.com/apache/bookkeeper/pull/2317
Please any fellow committer take a look and at least approve the patch (merging would be better) :-) I think it should also be cherry picked to branch-4.10 and to branch-4.9 if we want to cut other releases Enrico Il giorno mar 21 apr 2020 alle ore 11:18 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Hi, > this is my fix > https://github.com/apache/bookkeeper/pull/2317 > > I am not a Python expert, but my fix looks like a good workaround to > the problem. > It looks like Python grpcio released a new version that is not compatible > with our build system > > If the integration tests pass on GitHub actions I would like to commit > this patch ASAP > because we have all Pull Requests blocked by github actions failing on > this issue > > Enrico > > Il giorno dom 19 apr 2020 alle ore 17:59 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > >> Hi, >> I am not able to build the current-version-image docker image that >> contains the python client used for integration test. >> I guess it is the same error as on GitHub Actions >> >> Does anyone have an idea about how to fix this? >> >> I am on Fedora 31 + docker (no podman) >> >> The build fails consistently >> >> mvn clean install -DskipTests -Ddocker -DintegrationTests -rf >> :current-version-image >> >> below the error >> >> Maybe it is due to some auto upgrade of some python dependencies? >> It looks like we are not using a fixed version dependency, but something >> like: >> >> dependencies = [ >> 'protobuf>=3.0.0', >> 'requests<3.0.0dev,>=2.18.0', >> 'setuptools>=34.0.0', >> 'six>=1.10.0', >> 'pytz', >> 'futures>=3.2.0;python_version<"3.2"', >> 'grpcio>=1.8.2', >> 'pymmh3>=0.0.3' >> ] >> >> see >> >> https://github.com/apache/bookkeeper/blob/master/stream/clients/python/setup.py#L28 >> >> Enrico >> >> [INFO] Step 21/24 : RUN /opt/bookkeeper/scripts/install-python-client.sh >> [INFO] >> [INFO] ---> Running in 98f582464063 >> [INFO] ++ ls >> /opt/bookkeeper/bookkeeper-client/apache_bookkeeper_client-4.11.0-py2.py3-none-any.whl >> [INFO] >> [INFO] + >> WHEEL_FILE=/opt/bookkeeper/bookkeeper-client/apache_bookkeeper_client-4.11.0-py2.py3-none-any.whl >> [INFO] >> [INFO] + pip install >> /opt/bookkeeper/bookkeeper-client/apache_bookkeeper_client-4.11.0-py2.py3-none-any.whl >> [INFO] >> [INFO] Processing >> ./bookkeeper-client/apache_bookkeeper_client-4.11.0-py2.py3-none-any.whl >> [INFO] Collecting grpcio>=1.8.2 (from apache-bookkeeper-client==4.11.0) >> [INFO] Downloading >> https://files.pythonhosted.org/packages/cf/7a/9744998129fce7e29c5f2d8b0f545913b7383e65d8366fc0ae98d11936af/grpcio-1.28.1.tar.gz >> (19.5MB) >> [INFO] Complete output from command python setup.py egg_info: >> [INFO] Found cython-generated files... >> [INFO] error in grpcio setup command: 'install_requires' must be a >> string or list of strings containing valid project/version requirement >> specifiers >> >
