Thank you Dave can you please "Approve" the pull request ? Unfortunately Travis has problems and the build fails, I have started another thread to fix the problem
Enrico Il giorno ven 3 gen 2020 alle ore 15:24 David Rusek <dave.ru...@gmail.com> ha scritto: > Confirming what I said on slack, it’s not worth us maintaining these > modules. > > On Fri, Jan 3, 2020 at 5:54 AM Jia Zhai <zhaiji...@gmail.com> wrote: > > > +1 to remove it. > > > > Best Regards. > > > > > > Jia Zhai > > > > Beijing, China > > > > Mobile: +86 15810491983 > > > > > > > > > > On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > >> This is the patch > >> https://github.com/apache/bookkeeper/pull/2232 > >> > >> @Sijie @Dave please take a look > >> > >> Enrico > >> > >> Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli < > >> eolive...@gmail.com> > >> ha scritto: > >> > >> > Hi, > >> > on slack Dave Rusek told me it is useless to keep this stuff. > >> > It seems that he did not receive this message, I am posting this > message > >> > just to let him confirm > >> > > >> > btw I am preparing a patch that drops all of this stuff > >> > > >> > Enrico > >> > > >> > Enrico > >> > > >> > Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli < > >> > eolive...@gmail.com> ha scritto: > >> > > >> >> Hi folks, > >> >> I propose to drop the four modules that contain Twitter specific > stuff. > >> >> Those modules did not receive changes for long time, nor > >> issues/questions > >> >> from users. > >> >> > >> >> We recently added a new Maven profile (-Dtwitter) to skip them from > >> build. > >> >> > >> >> The modules are: > >> >> - Http Server: > >> >> > >> > https://github.com/apache/bookkeeper/blob/master/bookkeeper-http/twitter-http-server/pom.xml > >> >> - Finagle Stats Provider > >> >> > >> > https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-finagle-provider/pom.xml > >> >> - Science Stats Provider > >> >> > >> > https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-science-provider/pom.xml > >> >> - Ostrich Stats Provider > >> >> > >> > https://github.com/apache/bookkeeper/blob/master/bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml > >> >> > >> >> Best regards > >> >> > >> >> Enrico > >> >> > >> > > >> > > -- > > Dave Rusek > dave.ru...@gmail.com > @davidjrusek >
