Thank you Ivan for reporting this.
Please create an issue so that we can continue the discussion and provide a fix

I am cancelling this  vote now and drop the RC0

We need to work on the fix, it is better to continue the discussion on the 
issue tracker

Enrico


--

Enrico Olivelli
Software Development Manager @ Diennea - MagNews
Tel.: (+39) 0546 066100 - Int. 125
Viale G.Marconi 30/14 - 48018 Faenza (RA)

________________________________________
Da: Ivan Kelly <iv...@apache.org>
Inviato: venerdì 9 novembre 2018 16:58
A: dev@bookkeeper.apache.org
Oggetto: Re: [VOTE] Release 4.8.1, release candidate #0

-1 (binding)

So in general the release looks fine, but there's still the error I
flagged with 4.8.0.

2018-11-09 16:18:43,271 - ERROR - [main:DockerUtils@188] -
DOCKER.exec(bookkeeper1_6e7e4ddf-717d-42bb-8701-4717d5027c92:/opt/bookkeeper/4.8.1/bin/bkctl
ledger simpletest --ensemble-size 3 --write-quorum-size 3
--ack-quorum-size 2 --num-entries 100): failed with 1 : Exception in
thread "main" java.util.ServiceConfigurationError:
org.apache.bookkeeper.tools.framework.CommandGroup: Provider
org.apache.bookkeeper.stream.cli.ClusterCommandGroup not found
        at java.util.ServiceLoader.fail(ServiceLoader.java:239)
        at java.util.ServiceLoader.access$300(ServiceLoader.java:185)
        at 
java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:372)
        at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
        at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
        at org.apache.bookkeeper.tools.cli.BKCtl.main(BKCtl.java:52)

If you build without -Dstream bkctl is broken. If you build with  We
should either enable stream by default, or remove the bkctl dependency
on this class.

-Ivan

On Thu, Nov 8, 2018 at 10:24 AM, Enrico Olivelli <eolive...@gmail.com> wrote:
> +1 (binding)
>
> - checked checksum and signatures of the staged artifacts on dist
> - checked RAT over the staged source artifacts
> - run unit tests on JDK8 on Linux (Fedora 27)
> - run tests on JDK10 over a few projects on Linux (Fedora 27)
> - run basic tests on JDK8 with localbookie and "standalone mode"
>
> Enrico
>
> Il giorno gio 8 nov 2018 alle ore 10:21 Enrico Olivelli
> <eolive...@apache.org> ha scritto:
>>
>> Hi everyone,
>> Please review and vote on the release candidate #0 for the version
>> 4.8.1, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>> * Release notes [1]
>> * The official Apache source and binary distributions to be deployed
>> to dist.apache.org [2]
>> * All artifacts to be deployed to the Maven Central Repository [3]
>> * Source code tag "v4.8.1-rc0" [4] with git sha
>> 9f9f29f089958a13554056d901d293fad5614fa5
>>
>> BookKeeper's KEYS file contains PGP keys we used to sign this release:
>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>
>> Please download these packages and review this release candidate:
>>
>> - Review release notes
>> - Download the source package (verify shasum, and asc) and follow the
>> instructions to build and run the bookkeeper service.
>> - Download the binary package (verify shasum, and asc) and follow the
>> instructions to run the bookkeeper service.
>> - Review maven repo, release tag, licenses, and any other things you think
>> it is important to a release.
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Enrico Olivelli
>>
>> [1] https://github.com/apache/bookkeeper/pull/1795
>> [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.8.1-rc0/
>> [3] 
>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1034/
>> [4] https://github.com/apache/bookkeeper/tree/v4.8.1-rc0

________________________________

CONFIDENTIALITY & PRIVACY NOTICE
This e-mail (including any attachments) is strictly confidential and may also 
contain privileged information. If you are not the intended recipient you are 
not authorised to read, print, save, process or disclose this message. If you 
have received this message by mistake, please inform the sender immediately and 
destroy this e-mail, its attachments and any copies. Any use, distribution, 
reproduction or disclosure by any person other than the intended recipient is 
strictly prohibited and the person responsible may incur in penalties.
The use of this e-mail is only for professional purposes; there is no guarantee 
that the correspondence towards this e-mail will be read only by the recipient, 
because, under certain circumstances, there may be a need to access this email 
by third subjects belonging to the Company.

Reply via email to