+1 from me. Changing the tag was really bad practice. Good to see this changing.
On Tue, May 29, 2018 at 6:59 AM, Enrico Olivelli <eolive...@gmail.com> wrote: > Il mar 29 mag 2018, 02:50 Sijie Guo <guosi...@gmail.com> ha scritto: > >> Since I am going to cut a new release 4.7.1, I would like to change the >> release procedure for docker images, we don't need to retag release tags >> for updating docker files. >> >> Please take a look at this BP - >> https://github.com/apache/bookkeeper/pull/1450 > > > Already gave my +1 > Very good thank you > > Enrico > >> >> >> >> >> >> - Sijie >> >> On Wed, Apr 18, 2018 at 12:21 PM, Jia Zhai <zhaiji...@gmail.com> wrote: >> >> > +1 >> > >> > On Tue, Apr 17, 2018 at 2:17 PM, Enrico Olivelli <eolive...@gmail.com> >> > wrote: >> > >> > > Il mar 17 apr 2018, 20:57 Sijie Guo <guosi...@gmail.com> ha scritto: >> > > >> > > > Hi all, >> > > > >> > > > Current docker images are auto-built by apache docker account. It >> > > becomes a >> > > > bit problematic in the release process. We might consider moving the >> > > docker >> > > > build process out of apache main repo. >> > > > >> > > > So I am restarting the discussion about "official docker image", >> > > following >> > > > what flink is doing. flink maintains a separate repo: >> > > > https://github.com/docker-flink and update docker "official-images" >> > > repo. >> > > > >> > > > We can do the similar thing: >> > > > >> > > > - create an `apachebookkeeper` org and a `docker` repo under it >> > > > - update docker "official-images" >> > > > >> > > > The docker repo will be managed under bookkeeper pmc. So docker files >> > > > update will only be done when a bookkeeper release is completed, >> which >> > > > would make the release sequence clearer and also we are able to >> publish >> > > > "docker-official" images. >> > > > >> > > > Thoughts? >> > > > >> > > >> > > Totally +1 >> > > I really don't like that re-tagging procedure. >> > > >> > > Enrico >> > > >> > > >> > > >> > > > [1] https://docs.docker.com/docker-hub/official_repos/ >> > > > [2] https://github.com/docker-library/docs >> > > > [3] https://flink.apache.org/news/2017/05/16/official-docker- >> > image.html >> > > > >> > > > - Sijie >> > > > >> > > -- >> > > >> > > >> > > -- Enrico Olivelli >> > > >> > >> > -- > > > -- Enrico Olivelli
