Done. Thanks Jia! - Sijie
On Fri, Apr 13, 2018 at 11:53 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > On Fri, Apr 13, 2018 at 9:26 PM, Jia Zhai <zhaiji...@gmail.com> wrote: > >> Hi Sijie, >> would you please update the the sha1 files? >> It seems they point to your local path: >> ``` >> >> cat bookkeeper-4.7.0-src.tar.gz.sha1 >> >> 75db0fcb75cc35424fc171411b0f161dd905076c /Users/sijie/Workspaces/ >> bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.0- >> rc1/bookkeeper-4.7.0-src.tar.gz >> ``` >> > > Good catch. It comes from my script. I will update the sha1 and fix my > script. > > >> >> Besides this, others looks good. >> >> +1 >> >> - verified 3 packages checksum ( asc and sha1 all good) >> >> - the source package build and test all run successfully. >> >> - in both binary package(server & all), bin/bookkeeper and command >> localbookie runs well. >> >> >> >> >> On Sat, Apr 14, 2018 at 3:55 AM, Sijie Guo <guosi...@gmail.com> wrote: >> >> > Hi everyone, >> > >> > Please review and vote on the release candidate #0 for the version >> 4.7.0, >> > as follows: >> > [ ] +1, Approve the release >> > [ ] -1, Do not approve the release (please provide specific comments) >> > >> > The complete staging area is available for your review, which includes: >> > * Release notes [1] >> > * The official Apache source and binary distributions to be deployed to >> > dist.apache.org [2] >> > * All artifacts to be deployed to the Maven Central Repository [3] >> > * Source code tag "release-4.7.0" [4] with git >> > sha 03deee6c94383db6080031a510c9c28d0b083fc0 >> > >> > BookKeeper's KEYS file contains PGP keys we used to sign this release: >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS >> > >> > Please download these packages and review this release candidate: >> > >> > - Review release notes >> > - Download the source package (verify shasum, and asc) and follow the >> > instructions to build and run the bookkeeper service. >> > - Download the binary package (verify shasum, and asc) and follow the >> > instructions to run the bookkeeper service. >> > - Review maven repo, release tag, licenses, and any other things you >> think >> > it is important to a release. >> > >> > NOTE: 4.7.0 release introduced `circe-checksum` module, which currently >> > only ships a precompiled linux JNI lib along with the artifact. >> > >> > The vote will be open for at least 72 hours. It is adopted by majority >> > approval, with at least 3 PMC affirmative votes. >> > >> > Thanks, >> > Sijie Guo >> > >> > [1] https://github.com/apache/bookkeeper/pull/1330 >> > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/ >> > bookkeeper-4.7.0-rc1/ >> > [3] >> > https://repository.apache.org/content/repositories/ >> > orgapachebookkeeper-1029/ >> > [4] https://github.com/apache/bookkeeper/tree/release-4.7.0 >> > >> > >
