+1, - verified both packages checksum ( asc and sha1 all good)
- the source package build and test all run successfully. - in binary package, bin/bookkeeper and command localbookie runs well. On Tue, Apr 3, 2018 at 9:20 PM, Enrico Olivelli <eolive...@gmail.com> wrote: > +1 (binding) > > - Run manually basic tests with local bookie (on Fedora, with jdk8) > - Packaged bookkeeper-server.jar into real application (with known java9 > issues with BK) and run cleanly on jdk10 > - Verified artifacts and signatures on staging repository > > > Enrico > > > 2018-04-03 15:17 GMT+02:00 Ivan Kelly <iv...@apache.org>: > > > +1 lgtm > > > > RAT, FINDBUGS & TESTS: > > > > Runs cleanly. I had -Dsurefire.rerunFailingTestsCount=2 set, but I > > don't think anything even flaked. > > > > Minor issue: Vertx http tests expect 8080 to be free > > > > SHA1 & SIGs: > > > > Good. > > > > LICENSE & NOTICE: > > > > Nothing changed since 4.6.1, so looks good. > > > > Minor: Copyright in notice should include 2018 > > > > -Ivan > > > > On Tue, Apr 3, 2018 at 1:57 PM, Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > Hi everyone, > > > Please review and vote on the release candidate #2 for the version > 4.6.2, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "release-4.6.2" [4] with git sha > > > f142315ec18deec84cd2acf28aa4a8a932b24baf > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Enrico Olivelli > > > > > > [1] https://github.com/apache/bookkeeper/pull/1297/ > > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/ > > bookkeeper-4.6.2-rc2/ > > > [3] > > > https://repository.apache.org/content/repositories/ > > orgapachebookkeeper-1026/ > > > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2 > > >
