+1 on 3 forse me too Il mar 20 mar 2018, 09:15 Sijie Guo <guosi...@gmail.com> ha scritto:
> On Tue, Mar 20, 2018 at 12:50 AM, Ivan Kelly <iv...@apache.org> wrote: > > > On Mon, Mar 19, 2018 at 6:37 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > It is not a blocker for me. > > > > > > But if we want consistency, either applying pattern "asyncXYZ()" or > > > "xyzAsync()" for async operations works for me. > > xyzAsync is better than asyncXyz, as it will put the async and sync > > versions together in the javadoc. > > > > So, there's 3 options here. > > > > 1. Remove Closeable > > 2. Some kind of split of sealing and close > > 3. Create sync and async versions of all with Async suffix. > > > > I think 3 is the most palatable. If there's no objections I'll push a > > patch later today. > > > > +1 on 3 > > > > > -Ivan > > > -- -- Enrico Olivelli
