+1 Release notes is good checksums are good source and binary pages are good.
On Sun, Jan 28, 2018 at 2:50 PM, Yiming Zang <yz...@twitter.com.invalid> wrote: > +1 > > - MD5 SHA signature looks good > - Source code looks good > - Binary looks good > > On Sun, Jan 28, 2018 at 6:59 AM, David Rusek <dave.ru...@gmail.com> wrote: > > > I'll take a look first thing tomorrow morning. > > > > On Sun, Jan 28, 2018 at 3:23 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > Thank you all, > > > We need another PMC +1 > > > > > > Enrico > > > > > > Il ven 26 gen 2018, 17:42 Ivan Kelly <iv...@apache.org> ha scritto: > > > > > > > +1 > > > > > > > > - sha1, md5, gpg sigs are good > > > > - NOTICE and LICENSE are "good" > > > > - src passes rat, spotbugs, unit tests pass eventually > > > > - binary package and maven repo jar passed a run through Jepsen > > > > > > > > Good work Enrico! And sorry about the delay in voting. > > > > > > > > -Ivan > > > > > > > > On Wed, Jan 24, 2018 at 8:52 PM, Sijie Guo <guosi...@gmail.com> > wrote: > > > > > +1 > > > > > > > > > > - package checksums are good > > > > > - source package is good > > > > > - binary package is good > > > > > > > > > > - Sijie > > > > > > > > > > On Tue, Jan 23, 2018 at 11:16 PM, Enrico Olivelli < > > eolive...@gmail.com > > > > > > > > > wrote: > > > > > > > > > >> Thank you Jia, > > > > >> > > > > >> We need at least 3 PMC votes... > > > > >> > > > > >> Enrico > > > > >> > > > > >> Il sab 20 gen 2018, 16:32 Jia Zhai <zhaiji...@gmail.com> ha > > scritto: > > > > >> > > > > >> > +1, > > > > >> > > > > > >> > - verified packages checksum (md5, asc and sha1 all good) > > > > >> > > > > > >> > - the source package build and test all run successfully. > > > > >> > > > > > >> > - NOTICE, License headers in binary package look good. > > > > >> > > > > > >> > - in binary package, bin/bookkeeper and command localbookie runs > > > well. > > > > >> > > > > > >> > On Fri, Jan 19, 2018 at 9:58 PM, Enrico Olivelli < > > > eolive...@gmail.com > > > > > > > > > >> > wrote: > > > > >> > > > > > >> > > Hi everyone, > > > > >> > > Please review and vote on the release candidate #0 for the > > version > > > > >> > > 4.6.1, as follows: > > > > >> > > [ ] +1, Approve the release > > > > >> > > [ ] -1, Do not approve the release (please provide specific > > > > comments) > > > > >> > > > > > > >> > > The complete staging area is available for your review, which > > > > includes: > > > > >> > > * Release notes [1] > > > > >> > > * The official Apache source and binary distributions to be > > > deployed > > > > >> > > to dist.apache.org [2] > > > > >> > > * All artifacts to be deployed to the Maven Central Repository > > [3] > > > > >> > > * Source code tag "release-4.6.1" with gitsha > > > > >> > > 131e7baaf3ba6f2308b45bdbefa3cf9f2b6208ac [4] > > > > >> > > > > > > >> > > BookKeeper's KEYS file contains PGP keys we used to sign this > > > > >> > > release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > >> > > > > > > >> > > Please download these packages and review this release > > candidate: > > > > >> > > > > > > >> > > - Review release notes > > > > >> > > - Download the source package (verify md5, shasum, and asc) > and > > > > follow > > > > >> > the > > > > >> > > instructions to build and run the bookkeeper service. > > > > >> > > - Download the binary package (verify md5, shasum, and asc) > and > > > > follow > > > > >> > the > > > > >> > > instructions to run the bookkeeper service. > > > > >> > > - Review maven repo, release tag, licenses, and any other > things > > > you > > > > >> > think > > > > >> > > it is important to a release. > > > > >> > > > > > > >> > > The vote will be open for at least 72 hours. It is adopted by > > > > majority > > > > >> > > approval, with at least 3 PMC affirmative votes. > > > > >> > > > > > > >> > > Thanks, > > > > >> > > Enrico Olivelli > > > > >> > > > > > > >> > > [1] https://github.com/apache/bookkeeper/pull/980 > > > > >> > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/ > > > > >> > > bookkeeper/bookkeeper-4.6.1-rc/ > > > > >> > > [3] https://repository.apache.org/content/repositories/ > > > > >> > > orgapachebookkeeper-1024/ > > > > >> > > [4] > > > https://github.com/apache/bookkeeper/releases/tag/release-4.6.1 > > > > >> > > > > > > >> > > > > > >> -- > > > > >> > > > > >> > > > > >> -- Enrico Olivelli > > > > >> > > > > > > > > > > > > > -- > > > > > > > > > -- Enrico Olivelli > > > > > > -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi