On Mon, Jan 8, 2018 at 9:12 AM, Enrico Olivelli <eolive...@gmail.com> wrote:
> Il lun 8 gen 2018, 01:52 Sijie Guo <guosi...@gmail.com> ha scritto: > > > On Sun, Jan 7, 2018 at 11:43 AM, Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > Il dom 7 gen 2018, 20:38 Sijie Guo <guosi...@gmail.com> ha scritto: > > > > > > > Can you file an issue for that? I think maven release plugin should > > have > > > a > > > > command to do that or we have to include a paragraph in release guide > > to > > > do > > > > it. > > > > > > > > > > Yup > > > It is > > > Mvn release:update-versions > > > > > > But we have to update website config as well > > > > > > > Can you explain this more? Not sure what do you mean here. > > > > While performing a minor release we have to use script (release.sh) which > reads from the config of the website, see my last commit on branch 4.6 > I don't know how to handle this in a smart way, I am trying to change that > script but the solution is not immediate > The release.sh script would only work for master branch, because it handles all the documentation related updates, where documentation related updates should only happen to master. Minor release version bump only happens in branches. So these are two different things, you can't really change release.sh to achieve that. Add this command to release guide seems to be good enough at this moment. > Maybe this is another thread/topic > > Enrico > > > > > > > > > > Enrico > > > > > > > > > > > Sijie > > > > > > > > On Jan 7, 2018 6:07 AM, "Enrico Olivelli" <eolive...@gmail.com> > wrote: > > > > > > > > Hi, > > > > on branch 4.6 we still have wrong version, it SHOULD be > 4.6.1-SNAPSHOT > > > but > > > > actually is 4.6.0-SNAPSHOT, see (1) > > > > I will fix it manually in order to move the 4.6.1 release forward > > > > > > > > But we have to fix this in the major release flow, > > > > > > > > Enrico > > > > > > > > 1) > > > > > > https://github.com/apache/bookkeeper/blob/e52ffb04761443f45cd6fe2714d696 > > > > 0ca5cfdd2a/pom.xml#L26 > > > > <https://github.com/apache/bookkeeper/blob/ > > > e52ffb04761443f45cd6fe2714d6960ca5cfdd2a/pom.xml#L26> > > > > > > > -- > > > > > > > > > -- Enrico Olivelli > > > > > > -- > > > -- Enrico Olivelli >
