Can you check what other scala projects do regarding the LICENCE files, regarding scala license? How do their LICENCE files look like?
Sijie On Dec 14, 2017 4:07 AM, "Ivan Kelly" <iv...@apache.org> wrote: > -1 (binding) > > I really hate to do this again. I had everything checked out, and > everything was good. RAT, findbugs, tests (though there was a few > flakes, these are fixed in master), jepsen passed, notice files were > good. I was writing the +1 email, and typing that I had checked > "NOTICES and LICENSE", and realized I hadn't checked the LICENSE > files. > > In the LICENSE files we have licenses and copyright notices for SLF4J > and Protobuf, these are required by the "New BSD License". We have > since added two new New BSD jars, ParaNamer & Scala. Also, Java > Servlet is under CDDL. I'm not sure if CDDL requires the same as New > BSD and MIT. > > So, really sorry, but it has to be -1 again :( > > I'll make a PR this afternoon to fix the issues. > > -Ivan > > > > On Mon, Dec 11, 2017 at 10:51 AM, Jia Zhai <zhai...@apache.org> wrote: > > Hi everyone, > > > > Please review and vote on the release candidate #1 for the version > > 4.6.0, as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed > > to dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "release-4.6.0" [4] > > > > BookKeeper's KEYS file contains PGP keys we used to sign this > > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify md5, shasum, and asc) and follow > the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify md5, shasum, and asc) and follow > the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you > think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Jia Zhai > > > > [1] *https://github.com/apache/bookkeeper/pull/759 > > <https://github.com/apache/bookkeeper/pull/759>* > > [2] *https://dist.apache.org/repos/dist/dev/bookkeeper/ > bookkeeper-4.6.0-rc1/ > > <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc1/ > >* > > [3] > > https://repository.apache.org/content/repositories/ > orgapachebookkeeper-1022/ > > [4] https://github.com/apache/bookkeeper/tree/release-4.6.0 >
