Thank you Just a note (maybe I will start a new thread) but actually the merge scripts does merge --squash and the effect is the same as doing a rebase to master
I can't see this problem with the actual merge script, it works very well and on the git history we will have only one "commit" for issue. Usually during the discussion on GitHub it is good not to rebase and do force pushes in local branchs, this way the reviewer can see how its comments gets addressed. The GitHub UI is very powerful in aggregating the commits of the PR Sometimes I see it is better to do a "git rebase -i " and squash locally the commits before updating the PR Enrico Il giorno ven, 06/10/2017 alle 09.47 +0800, Jia Zhai ha scritto: 👍 On Fri, Oct 6, 2017 at 4:42 AM, Sijie Guo <guosi...@gmail.com<mailto:guosi...@gmail.com>> wrote: Hi all, Here is the meeting notes : https://cwiki.apache.org/confluence/display/BOOKKEEPER/ 2017-10-05+Meeting+Notes Please point out if I missed anything we discussed at the meeting. - Sijie -- Enrico Olivelli Software Development Manager @Diennea Tel.: (+39) 0546 066100 - Int. 925 Viale G.Marconi 30/14 - 48018 Faenza (RA) MagNews - E-mail Marketing Solutions http://www.magnews.it Diennea - Digital Marketing Solutions http://www.diennea.com ________________________________ Iscriviti alla nostra newsletter per rimanere aggiornato su digital ed email marketing! http://www.magnews.it/newsletter/ The information in this email is confidential and may be legally privileged. If you are not the intended recipient please notify the sender immediately and destroy this email. Any unauthorized, direct or indirect, disclosure, copying, storage, distribution or other use is strictly forbidden.
