sijie commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133080246
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##########
@@ -77,11 +73,25 @@
static class DefaultResolver implements DNSToSwitchMapping {
+ final Supplier<String> defaultRackSupplier;
+
+ // for backwards compat
+ public DefaultResolver() {
+ this(()->NetworkTopology.DEFAULT_REGION_AND_RACK);
Review comment:
add space "() -> Network"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
