Great! I think my vote has been lost :) anyway it was +1
Enrico Il gio 10 ago 2017, 18:00 Venkateswara Rao Jujjuri <jujj...@gmail.com> ha scritto: > I'm happy to announce that we have unanimously approved this release. > > There are 8 approving votes, 3 of which are binding: > > * JV Jujjuri > > * Sijie Guo > > * Matteo Merli > > * Jia Zhai > > * Govind Menon > > * Sam Just > > * Leigh Stewart > > There are no disapproving votes. > > Thanks everyone! > > > On Thu, Aug 10, 2017 at 12:37 AM, Sijie Guo <guosi...@gmail.com> wrote: > > > +1 > > > > - signatures are good > > - source package: build, rat check, and test > > - binary package: able to run local bookie, and tested on a docker > > environment. > > - distributedlog integration: distributedlog core library is able to > > compile, and all tests passed. > > > > - Sijie > > > > On Tue, Aug 8, 2017 at 4:07 PM, Leigh Stewart <agrodel...@gmail.com> > > wrote: > > > > > +1 (non-binding) > > > > > > - release notes look good > > > - built and ran localbookie from source package successfully > > > - ran localbookie from bin package successfully > > > > > > > > > On Tue, Aug 8, 2017 at 11:45 AM, Sam Just <sj...@salesforce.com> > wrote: > > > > > > > +1 > > > > > > > > On Tue, Aug 8, 2017 at 10:22 AM, Matteo Merli <mme...@apache.org> > > wrote: > > > > > > > > > +1 > > > > > > > > > > Checked src and bin package > > > > > * Signatures ok > > > > > * Build > > > > > * Rat > > > > > * Run local bookie > > > > > (I had to set allowLoopback=true in conf/bk_server.conf for > that. > > I > > > > > agree we can > > > > > document it and improve it later.) > > > > > > > > > > Matteo > > > > > > > > > > On Mon, Aug 7, 2017 at 7:13 AM Venkateswara Rao Jujjuri < > > > > jujj...@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on the release candidate #0 for version > > 4.5.0, > > > > as > > > > > > follows: > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > > > > > > > > > * Release Notes [1] > > > > > > * The official Apache source and binary distributions to be > > deployed > > > to > > > > > > dist.apache.org [2] > > > > > > * All artifacts to be deployed to the Maven Central Repository > [3] > > > > > > * Source code tag "release-4.5.0" [4] > > > > > > > > > > > > BookKeeper's KEY file contains PGP keys we use to sign this > > release: > > > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > > > > > > > Please review this release candidate. > > > > > > > > > > > > - Review release notes > > > > > > - Download the source package (verify md5, shasum, and asc) and > > > follow > > > > > the > > > > > > instructions to build and run the bookkeeper service. > > > > > > - Download the binary package (verify md5, shasum, and asc) and > > > follow > > > > > the > > > > > > instructions to run the bookkeeper service. > > > > > > - Review maven repo, release tag, licenses, and any other things > > you > > > > > think > > > > > > it is important to a release. > > > > > > > > > > > > [1] https://github.com/apache/bookkeeper/pull/402 > > > > > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/4.5.0-rc0/ > > > > > > [3] https://repository.apache.org/content/repositories/ > > > > > > orgapachebookkeeper-1012/ > > > > > > [4] https://github.com/apache/bookkeeper/tree/release-4.5.0 > > > > > > > > > > > > -- > > > > > > Jvrao > > > > > > --- > > > > > > First they ignore you, then they laugh at you, then they fight > you, > > > > then > > > > > > you win. - Mahatma Gandhi > > > > > > > > > > > -- > > > > > Matteo Merli > > > > > <mme...@apache.org> > > > > > > > > > > > > > > > > > > -- > Jvrao > --- > First they ignore you, then they laugh at you, then they fight you, then > you win. - Mahatma Gandhi > -- -- Enrico Olivelli
