sijie commented on a change in pull request #424: Issue 414: use a clone of
baseconf in new ServerConfiguration(baseConf)
URL: https://github.com/apache/bookkeeper/pull/424#discussion_r132266862
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##########
@@ -127,18 +127,8 @@ public void loadConf(URL confURL) throws
ConfigurationException {
* @param baseConf
* Other Configuration
*/
- public void loadConf(AbstractConfiguration baseConf) {
- addConfiguration(baseConf);
- }
-
- /**
- * Load configuration from other configuration object
- *
- * @param otherConf
- * Other configuration object
- */
- public void loadConf(Configuration otherConf) {
- addConfiguration(otherConf);
+ public void loadConf(CompositeConfiguration baseConf) {
Review comment:
Any reason you changed this to `CompositeConfiguration`? You can do
```java
addConfiguration((Configuration) baseConf.clone());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
