+1 (non binding) - Built from source package success; - Run local bookies success with built binary and downloaded; - Verified md5, sha1 and asc for both src and bin tgz, all success; - Run the binary in Docker environment and tested with 3 bookies deployment and tests, all success.
Also created 2 trivial issues, which related to unit-tests and could fix them in future. https://github.com/apache/bookkeeper/issues/414 https://github.com/apache/bookkeeper/issues/415 On Tue, Aug 8, 2017 at 5:17 AM, Enrico Olivelli <eolive...@gmail.com> wrote: > +1 (non binding) > > built from source package and run local bookie with basic commands > used binary package and run basic tests > > ran Majordodo and other projects unit tests against the rc0 and all looks > great > > I have created a couple of minor trivial issues to be addresses in future > releases or next rc > https://github.com/apache/bookkeeper/issues/410 -> a legacy CHANGES.txt > file is present in the binary distribution > https://github.com/apache/bookkeeper/issues/409 -> guava jar is still > present on classpath on bookie but it is useless as guava code has been > shaded and relocated > > It has been great for me to work at this super release! > > -- Enrico > > > 2017-08-07 22:33 GMT+02:00 Govind Menon <gme...@yahoo-inc.com.invalid>: > > > +1 > > > > On Monday, August 7, 2017, 9:13:32 AM CDT, Venkateswara Rao Jujjuri < > > jujj...@gmail.com> wrote: > > > > Hi everyone, > > > > Please review and vote on the release candidate #0 for version 4.5.0, as > > follows: > > > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > > > * Release Notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "release-4.5.0" [4] > > > > BookKeeper's KEY file contains PGP keys we use to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please review this release candidate. > > > > - Review release notes > > - Download the source package (verify md5, shasum, and asc) and follow > the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify md5, shasum, and asc) and follow > the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you > think > > it is important to a release. > > > > [1] https://github.com/apache/bookkeeper/pull/402 > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/4.5.0-rc0/ > > [3] https://repository.apache.org/content/repositories/ > > orgapachebookkeeper-1012/ > > [4] https://github.com/apache/bookkeeper/tree/release-4.5.0 > > > > -- > > Jvrao > > --- > > First they ignore you, then they laugh at you, then they fight you, then > > you win. - Mahatma Gandhi > > >
