yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r130436614
########## File path: bookkeeper-http/http-server/src/main/java/org/apache/bookkeeper/http/service/ServiceResponse.java ########## @@ -0,0 +1,57 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.http.service; + +import org.apache.bookkeeper.http.HttpServer; + +/** + * A wrapper class that wrap the result from service, which + * can then be parsed into http response. + */ +public class ServiceResponse { + private String body; + private HttpServer.StatusCode code = HttpServer.StatusCode.OK; + + public ServiceResponse() {} + + public ServiceResponse(String body, HttpServer.StatusCode code) { + this.body = body; + this.code = code; + } + + public String getBody() { Review comment: I think for the first version, maybe let's not make it that complicated? We currently don't expected very huge response (is larger than a single String can handle). We have an API in Twitter, which return all the ledgers that is underreplicated, and the largest response once return 300k ledgerIds, and it also works fine. So I think for the current being, "String" is probably good enough, we can definitely extend the behavior in the future if we have more strong requirements. What do you think? @eolivelli ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
