eolivelli commented on a change in pull request #301: Issue-299
EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129762207
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/GenericEnsemblePlacementPolicyTest.java
##########
@@ -132,9 +132,9 @@ public void testReplaceBookie() throws Exception {
lh.addEntry(value);
}
}
- assertEquals(2, customMetadataOnNewEnsembleStack.size());
Review comment:
@sijie for instance I have a custom policy, which implements only old
methods like the one in:
LegacyCustomDefaultEnsemblePlacementPolicyTest.java
this is a real example:
https://github.com/diennea/herddb/blob/master/herddb-core/src/main/java/herddb/cluster/PreferLocalBookiePlacementPolicy.java
this example does not even extends DefaultEnsamblePlacementPolicy, so my
current patch will not work :-(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
