sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry
fails with NPE with LedgerHandlerAdv
URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127800976
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -720,8 +720,7 @@ public void asyncAddEntry(final byte[] data, final
AddCallback cb,
* @param ctx
* some control object
*/
- public void asyncAddEntry(final long entryId, final byte[] data, final
AddCallback cb, final Object ctx)
- throws BKException {
+ public void asyncAddEntry(final long entryId, final byte[] data, final
AddCallback cb, final Object ctx) {
Review comment:
in LedgerHandleAdv, we should not allow adding entries without providing any
entry id. Otherwise, the semantic is too complicated to maintain. As it is hard
to tell, -1 is a user provided entry id or it is provided by calling addEntry
without an entry id.
/cc @jvrao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
