sijie commented on a change in pull request #231: Issue 230: Add Checkstyle to
the build process (Part 1)
URL: https://github.com/apache/bookkeeper/pull/231#discussion_r126635249
##########
File path: bookkeeper-stats-providers/twitter-ostrich-provider/pom.xml
##########
@@ -32,6 +32,38 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.libdir>${basedir}/lib</project.libdir>
</properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
Review comment:
@eolivelli I think we can do it at the end of the work. This is just first
part of #230. We don't have to be blocked on here. Your comments on moving the
configuration and version to pluginManagement in the root pom can be the last
pull request on addressing #230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
